Skip to content

fix: change outdated deps indicator#2883

Open
typed-sigterm wants to merge 1 commit into
npmx-dev:mainfrom
typed-sigterm:main
Open

fix: change outdated deps indicator#2883
typed-sigterm wants to merge 1 commit into
npmx-dev:mainfrom
typed-sigterm:main

Conversation

@typed-sigterm

@typed-sigterm typed-sigterm commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Linked issue

N/A for tiny fix.

🧭 Context

lucide:circle-alert is too serious, users may think it means security vulnerabilities.

📚 Description

Change icon to lucide:circle-fading-arrow-up.

Before:
image

After:
image

@typed-sigterm
fix: change icon of outdated deps
90412cc 
`lucide:circle-alert` is too serious, users may think it means security vulnerabilities. Changed to `lucide:circle-fading-arrow-up`.
@vercel

vercel Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jun 9, 2026 4:24am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jun 9, 2026 4:24am
npmx-lunaria Ignored Ignored Jun 9, 2026 4:24am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Dependencies component's outdated dependency status indicator icon was updated from a circle-alert glyph to a circle-fading-arrow-up glyph. This is a single-line visual change with no alterations to component logic or data handling.

Changes

Dependencies Icon Update

Layer / File(s) Summary
Outdated dependency indicator icon
app/components/Package/Dependencies.vue		 The icon glyph for outdated dependencies was changed from i-lucide:circle-alert to i-lucide:circle-fading-arrow-up to better represent the update-available state.

Suggested reviewers

  • ghostdevv
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: replacing the outdated dependency indicator icon with a new one.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the icon replacement from circle-alert to circle-fading-arrow-up with context and visual comparison.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @typed-sigterm! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@typed-sigterm

typed-sigterm commented Jun 9, 2026

Copy link
Copy Markdown
Author

Also, outdated deps should not be red. It's a harmless option of maintainers, unlike security vulnerabilities.

gameroman
gameroman reviewed Jun 9, 2026
View reviewed changes

@gameroman gameroman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add before-after screenshots, please

@typed-sigterm

typed-sigterm commented Jun 16, 2026

Copy link
Copy Markdown
Author

Added in description

@typed-sigterm typed-sigterm requested a review from gameroman June 16, 2026 09:35
@gameroman

gameroman commented Jun 16, 2026

Copy link
Copy Markdown
Member
image

I like this, but I think it looks a bit unreadable at small size?

Do you think we could do the arrow without circle? Or maybe you have some other better ideas

Maybe clock-arrow-up or circle-plus?

I want to know what others think too

@gameroman gameroman added the needs review This PR is waiting for a review from a maintainer label Jun 16, 2026
@gameroman gameroman requested a review from a team June 16, 2026 13:24
@gameroman gameroman added the front Frontend, Design label Jun 16, 2026
@alfonsusac

alfonsusac commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

I made several mock-ups trying various options especially: clock-arrow-up and square-arrow-up. We've discussed this in Discord and decided that arrow-up fits well. We avoided border to not make it similar to an "alert" badge (the one with shield and checkmark) and it also has easily distinguishable overall shape (arrow).

Mock-up for arrow-up
image

@trueberryless

trueberryless commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I agree that the current icons and colours might be misleading. When the feature was released I was a little confused myself.

I really like the icon you chose, I think the simple arrow is a too... well simple. But I agree we probably want more opinions on this.

@trueberryless trueberryless added the needs discussion An idea that needs more discussion to understand the scope and impact. label Jun 16, 2026
@MatteoGabriele

MatteoGabriele commented Jun 16, 2026

Copy link
Copy Markdown
Member

My 2 cents: I think the best one would be "i-lucide:history", but this icon renders way too small for all those details, so if we want something that brings attention without overwhelming, I think a simple "i-lucide:triangle" could just work.

Screenshot 2026-06-16 at 22 46 36

@typed-sigterm

typed-sigterm commented Jun 17, 2026

Copy link
Copy Markdown
Author

Perhaps it's also unnecessary to set error colors on deps with newer major versions

@43081j

43081j commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I'd go with what Matteo suggested, but would leave the colouring for a separate PR.

though my opinion on that is that we should still colour majors vs minors differently, maybe just not red if people are concerned about that being too strong of a signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gameroman gameroman Awaiting requested review from gameroman

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

front Frontend, Design needs discussion An idea that needs more discussion to understand the scope and impact. needs review This PR is waiting for a review from a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@typed-sigterm @gameroman @alfonsusac @trueberryless @MatteoGabriele @43081j